Return all tasks for a commit when querying recent tasks #1971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyHillers
approved these changes
Jul 12, 2022
| }) async* { | ||
| await for (Commit commit in queryRecentCommits(limit: commitLimit, branch: branch, slug: slug)) { | ||
| final Query<Task> query = db.query<Task>(ancestorKey: commit.key) | ||
| ..limit(taskLimit) |
Contributor
There was a problem hiding this comment.
TIL we've had this for 3 years, and I don't think anything used it
Contributor
Author
There was a problem hiding this comment.
refresh_chromebot_status is using it as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: flutter/flutter#100793
The function
queryRecentTasksis being used by bothrefresh_chromebot_statusandbatch_backfillerAPIs. It has causedbatch_backfillernot working appropriately. Strangely lucky thatrefresh_chromebot_statusis working. I wonder if this is achieved by multiple retries. Hopefully this will also help status refresh faster.