Skip to content

[scheduler] Increment task attempts and reset status on reruns #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Mar 10, 2022
Merged

[scheduler] Increment task attempts and reset status on reruns #1656

fluttergithubbot merged 1 commit into from
Mar 10, 2022

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Mar 10, 2022

This is to fix the attempts on Cocoon scheduled tasks.

Example

image

Issue

flutter/flutter#92300

@CaseyHillers CaseyHillers requested a review from keyonghan March 10, 2022 14:45
@CaseyHillers CaseyHillers mentioned this pull request Mar 10, 2022
Merged
keyonghan
keyonghan approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers added the waiting for tree to go green Merge PR when tree becomes green via fluttergithubbot label Mar 10, 2022
@fluttergithubbot fluttergithubbot merged commit 4bd47fb into flutter:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green Merge PR when tree becomes green via fluttergithubbot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CaseyHillers @keyonghan @fluttergithubbot