Test target dimensions in presubmit #1597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyHillers
approved these changes
Feb 10, 2022
| } | ||
|
|
||
| /// Get dimensions from target properties. | ||
| List<RequestedDimension> getDimensions(Map<String, dynamic>? properties) { |
Contributor
There was a problem hiding this comment.
This can be done later since P0, but can we move all the dimension logic be moved into model/ci_yaml/target.dart?
godofredoc
reviewed
Feb 10, 2022
| } | ||
|
|
||
| // Dimension list defined in .ci.yaml. | ||
| List<String> get dimensionList => <String>['os', 'device_os', 'device_type', 'mac_model']; |
Contributor
There was a problem hiding this comment.
Good enough for now to fix the current problem but in a future change we should do this in a generic way. Maybe a property called dimensions with an arbitrary dictionary.
Contributor
Author
There was a problem hiding this comment.
Yeah, only appended those used in our ci.yaml.
godofredoc
approved these changes
Feb 10, 2022
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inject dimensions from PRs in presubmit to test corresponding changes.
Fixes: flutter/flutter#98214
Related: flutter/flutter#97303