Revert "Do not try to submit if PR is not mergeable." #1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cdfddc6.
Contributor
Author
|
Further discussion is ongoing in flutter/flutter#91035 |
Contributor
|
Should we land the logging part first? we may not be able to find the issue if we revert now. |
CaseyHillers
approved these changes
Sep 30, 2021
godofredoc
approved these changes
Sep 30, 2021
Contributor
godofredoc
left a comment
There was a problem hiding this comment.
We may also need to revert the logging PR
Contributor
Author
I resolved the conflict. We can revert the logging change independently if desired after. |
|
This pull request is not suitable for automatic merging in its current state.
|
…t_submit_mergeable
72c506f to
e46eed6
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1368
Fixes flutter/flutter#91035
We need the bot to leave the "waiting for tree to go green" label on PRs that are green EXCEPT for the
luci-fluttercheck