-
Notifications
You must be signed in to change notification settings - Fork 100
Revert "Support test ownership validation" #1304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Support test ownership validation" #1304
Conversation
This reverts commit 658457f.
godofredoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@keyonghan i'll add an integration test for this script today to prevent future breakages |
|
The failure here doesn't seem related to the cocoon change. I have manually run an led execution based on this PR, it passes: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/8030b72f2ea91065bba62096309f224d1e6777c4bee9458627a5c2ee9111e027/+/build.proto Looking at the failure message (https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8840310077976904864/+/u/stderr), it has been happening on earlier tests (like this one: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8840340505364695696/+/u/stderr) |
|
https://ci.chromium.org/p/flutter/g/cocoon/console The reason it was reverted is because generate_jspb step started to fail in the ci.yaml roller on that commit. |
Reverts #1301
Reverting for flutter/flutter#87321