This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Update dart_roller_helper.py to explicitly pass --local-engine-host to the flutter tool.
#751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t` to the `flutter` tool.
13 tasks
Contributor
|
We can delete this script, it's no longer used now that we're using the Skia autoroller. I'll upload a PR when I get into the office today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial work towards flutter/flutter#132245.
These changes are intended to have no semantic change in behavior. Currently the host configuration is guessed by an internal heuristic, but we're switching it to have an explicit configuration instead. In other words, this is future proofing.
(Worth noting, I'm not actually sure if it's important to have a correct host configuration in release mode)