Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Add some options to make wasm debugging work better. #710

Merged
auto-submit merged 1 commit into from
Apr 12, 2023
Merged

Add some options to make wasm debugging work better. #710

auto-submit merged 1 commit into from
Apr 12, 2023

Conversation

@eyebrowsoffire
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire commented Apr 10, 2023

These changes go along with the changes in this PR: https://github.com/flutter/engine/pull/41054/files

@eyebrowsoffire eyebrowsoffire mentioned this pull request Apr 10, 2023
Merged
@eyebrowsoffire eyebrowsoffire requested a review from mdebbar April 11, 2023 00:35
yjbanov
yjbanov approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 12, 2023
@auto-submit auto-submit bot merged commit b6c4d42 into master Apr 12, 2023
@tamird tamird deleted the wasm_debugging branch June 20, 2023 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mdebbar mdebbar Awaiting requested review from mdebbar

1 more reviewer

@yjbanov yjbanov yjbanov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eyebrowsoffire @yjbanov