Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Remove iOS bitcode properties, stop using Xcode toolchain #634

Merged
jmagman merged 1 commit into from
Oct 5, 2022
Merged

Remove iOS bitcode properties, stop using Xcode toolchain #634

jmagman merged 1 commit into from
Oct 5, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Oct 4, 2022

Bitcode has been deprecated. Remove enable_bitcode and bitcode_marker properties. Usage removed in engine with flutter/engine#36596.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Oct 4, 2022
@jmagman jmagman marked this pull request as ready for review October 4, 2022 22:59
@jmagman jmagman requested review from dnfield and zanderso October 4, 2022 22:59
@jmagman
Copy link
Member Author

jmagman commented Oct 4, 2022

Going to wait until flutter/engine#36596 rolls and bakes in the framework for a bit before merging this and rolling the buildroot.

cbracken
cbracken approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emphatic lgtm!

@jmagman jmagman merged commit 5da1cbc into flutter:master Oct 5, 2022
@jmagman jmagman deleted the remove-bitcode branch October 5, 2022 20:23
@jmagman jmagman mentioned this pull request Oct 5, 2022
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dnfield dnfield Awaiting requested review from dnfield

2 more reviewers

@cbracken cbracken cbracken approved these changes

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @cbracken @zanderso