This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Remove default sources assignment filters. #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a pattern used by GYP and has since been abandoned in favor of conditionally adding the right sources and dependencies to GN targets. The assignment filter makes debugging linker issues due to filtered source files or dependencies extremely hard to isolate. All uses of this “feature” in the Flutter buildroot have been to disable the same. Dependencies already assume that no filters are present as other buildroots (Fuchsia) don’t define these either.
Contributor
Author
|
As discussed with @jamesr after spending an inordinate amount of time again debugging why an assignment was being silently ignored. |
Member
|
RSLGTM. Despite the slight increase in tediousness, the less magic in build systems the better. |
cbracken
approved these changes
May 14, 2019
Contributor
Author
We have never taken advantage of this feature. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a pattern used by GYP and has since been abandoned in favor of conditionally adding the right sources and dependencies to GN targets. The assignment filter makes debugging linker issues due to filtered source files or dependencies extremely hard to isolate. All uses of this “feature” in the Flutter buildroot and engine have been to disable the same. Dependencies already assume that no filters are present as other buildroots (Fuchsia) don’t define these either.