-
Notifications
You must be signed in to change notification settings - Fork 111
Floating cursor gif #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating cursor gif #226
Conversation
|
Normally we'd want the image to be generated, but in this case it's a capture of a native feature, so I don't see the need. This seems fine to me. |
gspencergoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
In 5 years when iOS looks completely different, will we want to use this same diagram? Or does it need updating every few months for iOS changes? |
|
(If the goal is to show the difference between the floating cursor and the background cursor, it might be ideal to move the cursor around much more slowly in the GIF; the way it spins right now at the start makes it quite distracting if you're trying to see what the cursor is doing, and it never really stays still for long enough to fully understand it.) |
|
Before anyone merges this can you please try adding the 'autosubmit' label to see if the bot can merge it? |
|
@justinmc we just rolled out autosubmit to this repo. Please add the autosubmit label to merge. |
|
Justin is OOO until January. @Hixie are you OK with this merging, or do you want to do something different? |
|
In the absence of a reason to do otherwise, I would feel more comfortable if this was an easily reproducible automated recording that used a slower pace than in the current GIF (per my comments above). |
|
I'm going to close this and explain the floating cursor in flutter/flutter#133002 without a visual aid. It's not possible to generate this image automatically because it requires interacting with a specific part of the soft keyboard. |

For a docs improvement around the floating cursor feature, in: flutter/flutter#133002
I wasn't sure if I needed to run any generation scripts or anything after adding the file, please let me know!
Also, is it OK that this is 1. a gif and 2. not generated from a script? I wanted an animation of the native floating cursor feature.