update json-ld and db deps - prevent variable expansion#91
Merged
Conversation
bplatz
approved these changes
Sep 12, 2024
| :git/sha "1eb181cb3c66f865c77493765d8d429af4359755"} | ||
| com.fluree/json-ld {:git/url "https://github.com/fluree/json-ld.git" | ||
| :git/sha "0958995acf5540271d1807fc6d8f2da131164e24"} | ||
| :git/sha "7ae310b2d8c0aaf10e107e094607f69464ed3447"} |
Contributor
There was a problem hiding this comment.
Wouldn't we be better off not having this as a dependency here at all, and only in fluree/db?
I believe with both, we don't have control over which one is used if they are different.
Contributor
Author
There was a problem hiding this comment.
I thought about that as I bumped it, but if we're using it directly I think we should depend on it directly. The build process does the right thing with regard to transitive deps, so there's no size/perf downside to specifying it either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.