Conversation
Closed
dpetran
reviewed
Jul 24, 2024
dpetran
reviewed
Jul 24, 2024
dpetran
reviewed
Jul 24, 2024
dpetran
reviewed
Jul 24, 2024
dpetran
reviewed
Jul 24, 2024
| (def options | ||
| [["-p" "--profile PROFILE" "Run profile" | ||
| :parse-fn keyword] | ||
| ["-c" "--config FILE" "Configuration file path"] |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes the main configuration file format from edn to json. It also allows users to override default configuration values in two ways: using a "profiles" key in the json configuration, and through environment variables.
An example configuration file can be found in resource/config.json.
This patch also adds initial validation of user configurations, but the validations are only a first pass and are not as restrictive and precise as they should be, and we should tighten them up later after the config format stabilizes.
This patch also has some cleanup left over from #75