Merged
Conversation
Contributor
|
Haven't had a chance to review this yet, but I will say that my upcoming nexus component PRs were going to contain a suggestion that we replace donut with integrant everywhere so we aren't dealing with two different approaches / libraries. So I'm very happy to see this! |
cap10morgan
approved these changes
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch replaces donut.system with integrant. I believe it simplifies configuration management and the system lifecycle a great deal while avoiding to impose an architecture on the application.
I decided to make this change because of the experience I had with adding the migrator component the first time and knowing we would have to repeat that process again soon, the difficulty I had with debugging server timeouts and tracing through the execution stack, and because @cap10morgan's good experience with using integrant with components he was working on and my past positive experiences with integrant.