Conversation
zonotope
approved these changes
Jun 17, 2024
| @@ -0,0 +1,44 @@ | |||
| (ns fluree.server.consensus.msg-format) | |||
|
|
|||
| ;; to the extent messages through consensus can be shared across | |||
Contributor
There was a problem hiding this comment.
This looks like an ns docstring instead of a comment
GitHub stopped supporting custom runner labels
Not all implementations are "groups"
These components explicitly interact with the consensus subsystem, so they should come under the consensus namespace hierarchy.
…nent Standalone consensus component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a new consensus type of
:noneand updates the default config to use this new type.Currently raft consensus is run by default even in single-server configurations.
Using no consensus doesn't change much - instead of using raft and multiple communication points for ordering/persisting data redundantly,
:noneconsensus uses a simple async chan loop.Right now it implements all transactions for all local ledgers in a single queue. One obvious improvement would be to spawn separate queues for each ledger as they can be worked on in parallel without issue.
There is definitely some refactoring/improvements that can be made in organizing and reusing consensus code. This does a few things in that direction, but the focus here was a new feature - not a refactor.