Skip to content

Fix/save raw txn#61

Merged
dpetran merged 3 commits intomainfrom
fix/save-raw-txn
May 14, 2024
Merged

Fix/save raw txn#61
dpetran merged 3 commits intomainfrom
fix/save-raw-txn

Conversation

@dpetran
Copy link
Contributor

@dpetran dpetran commented May 9, 2024

dpetran added 3 commits May 9, 2024 15:56
The tx-id we were returning to the client was not the same as the hash of the txn that
we persist in the store. Now we calculate the txn-id the same way.
@dpetran dpetran requested a review from a team May 9, 2024 21:17
@Jackamus29
Copy link
Collaborator

Jackamus29 commented May 10, 2024

This works great Dan!
The only thing I see is that the txn file has a .json file extension, but in my case with the JWS, it’s really just a text file.
Definitely not a show-stopper from my perspective, though!

@dpetran dpetran merged commit 9be5319 into main May 14, 2024
@dpetran dpetran deleted the fix/save-raw-txn branch May 14, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants