Conversation
t values returned by db are now always positive.
We no longer have "id" flakes, so this query will come back empty after the delete transaction executes.
cap10morgan
approved these changes
Feb 22, 2024
Contributor
cap10morgan
left a comment
There was a problem hiding this comment.
One nit-pick-y suggestion on the .gitignore addition, but LGTM o/w!
.gitignore
Outdated
| /.clj-kondo/* | ||
| !/.clj-kondo/config.edn | ||
| /.lsp/ | ||
| /.dir-locals.el |
Contributor
There was a problem hiding this comment.
Would be better to put this in your global git ignore file in your home dir.
This is the bare minimum change necessary to get things basically working: - fs/write-file now happens on a different thread - stop using file-conn directly, that should only be touched through a protocol - file-conn/address-full-path doesn't exist anymore, inlined the old behavior, will deprecate in next few commits
Instead of just writing to the filesystem willy-nilly, use the connection's :store.
Task/adopt storage proto
The connection type should not concern anything outside of the connection implementation code because the connections should behave exactly the same when interacting through the connection api/protocol. If they don't behave the same, then something is wrong with the api/protocol and we should fix that instead of dispatching on connection type outside of the connection implementation.
The large buffer will allow indexers to proceed without blocking until heavy volume, and setting the event type here means that we don't have to maintain the event format across codebases that should be independent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates server work with the db library using SID objects introduced in fluree/db#660. The api is very similar on the db side, so the only things that had to change here are (1) removing the negation of t-values in commit responses because those values are now always positive, and (2) removing the expectation that the "id" attribute will exist after a deletion because we no longer have "id" flakes in the db.