Conversation
dpetran
reviewed
Apr 14, 2025
| deref!) | ||
| commit-result (deref! (fluree/apply-stage! ledger staged-db))] | ||
| opts* (update opts :meta ensure-file-reports) | ||
| commit-result (deref! (fluree/transact! conn txn opts*))] |
Contributor
There was a problem hiding this comment.
Nice to see we're finally using this api in server!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds functions to transform consensus events to store any transactions they contain to connection storage and replace those transactions with transaction addresses. It also changes the standalone transactor to check if any transactions need to be resolved from storage (and resolve them if necessary) before attempting to process consensus events. It also simplifies the transaction/create handlers and the transaction processing to rely more on the default behavior of the db library instead of checking whether ledgers exist, and stage and committing transactions instead of transacting directly here when that's already done by the db library.