Conversation
If no cached shapes are found in a transaction that has no shape flakes, no validation will be performed.
Contributor
Author
|
Tests are currently in the server PR: I've got some tests in fluree/server#130. |
10f5ba1 to
ae525a9
Compare
Contributor
Author
|
The CI linter revealed that we have no I'm not sure why the linter started complaining now, but they were pretty straightforward. |
zonotope
approved these changes
Apr 10, 2025
src/fluree/db/flake/flake_db.cljc
Outdated
| (if (= commit-t index-t) | ||
| indexed-db* | ||
| (<? (load-novelty commit-catalog indexed-db* index-t commit-jsonld))))))) | ||
| (<? (shacl/hydrate-shape-cache! |
Contributor
There was a problem hiding this comment.
I think you should add another let binding here instead of this deeply nested async call.
src/fluree/db/json_ld/shacl.cljc
Outdated
| (let [new-shapes (<? (rebuild-shapes db))] | ||
| (reset-shape-cache! db new-shapes) ;; TODO - there is really no reason this needs to be an atom any longer | ||
| (vals new-shapes)))) | ||
| (reset-shape-cache! db new-shapes) |
Contributor
There was a problem hiding this comment.
I think you should change the reset-shape-cache! function to return the db it was passed in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading an existing ledger we need to hydrate the SHACL shape cache. If no cached shapes are found in a transaction that has no shape flakes, no validation will be performed.