Return full commits from remote nameservices#968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#965 changed the
lookup-commitnameservice api method to return the full latest commit document instead of just the address of the latest commit. However, the commit document returned was expanded in our proprietary format instead of expanded or compact jsonld, and this change wasn't implemented for remote nameservices.This patch extends on #965 to return compact jsonld from the
lookup-commitapi method, and it changes the behavior of remote nameservices to match storage-based and ipns based nameservices.I thought about fixing these issues while keeping the original goal of #965 by making changes to stop storing the index in the commit document, and instead store indexes and commits separately while adding another nameservice api method to retrieve the latest index. I think this is what we should do eventually as it will simplify the system and prevent other issues, but I chose to do the most expedient thing right now to fix the immediate problem.