Remove cyclic namespace dependencies and Connection/Ledger protocols#888
Merged
Remove cyclic namespace dependencies and Connection/Ledger protocols#888
Conversation
The commit should be validated upstream of this method at read time
This ns is still referencing the conn attached to db. That needs to be cleared up in a later commit.
and invert the dependency between ledger and connection namespace
…o refactor/encapsulate-connection
dpetran
reviewed
Sep 10, 2024
| (-did [conn] "Returns optional default did map if set at connection level") | ||
| (-nameservices [conn] "Returns a sequence of all nameservices configured for the connection.")) | ||
|
|
||
| (defprotocol iStorage |
dpetran
approved these changes
Sep 10, 2024
Contributor
dpetran
left a comment
There was a problem hiding this comment.
This looks great. I love to see the payoff of all the refactoring you've been doing, having everything be dispatched from the Connection is a big step forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes cyclic dependencies in a lot of namespaces involving both the connection and ledger namespaces, which allowed us to also remove the connection protocols, and allows us to use connections as the "entry point" and api for the database so that different components are now agnostic about which components they sit alongside of to manage the system.
This patch is based on #882, so please review that, and all of the prs that #882 depends on, first.