Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses:
a) Policy-modify logic bug that would get hit in certain policy combos fixed
b) Return 403 for policy exception
c)
query-connection-fqlbypassed parsing, and could only be used by keyword-based queries (not string keys). This wasn't exposed before because fluree/server was the only one using it, and it parses queries as well... so they were parsed before hitting the API.d)
transact!API did not enforce policy. fluree/server implemented it's own custom transact function (addressed in an upcoming PR) instead of using the fluree/db API so it wasn't exposed.