Include opts in SPARQL queries by JaceRockman · Pull Request #800 · fluree/db

JaceRockman · 2024-06-05T22:05:02Z

Allow opts to be added to SPARQL queries for credential purposes.

src/clj/fluree/db/api/query.cljc

bplatz · 2024-07-08T20:26:07Z

Is this still desired, or should this be closed?

JaceRockman · 2024-07-08T21:18:36Z

Is this still desired, or should this be closed?

I think we want to be able to restrict SPARQL queries by role still. Why would we no longer want that?

bplatz · 2024-07-08T21:22:48Z

I think we want to be able to restrict SPARQL queries by role still. Why would we no longer want that?

That sounds good. The new policy-queries no longer has roles, there is the new wrap-identity-policy API which would be the closest approximation to this.

src/clj/fluree/db/query/api.cljc

This allows a role to be added to SPARQL queries.

Also adds tests for this behavior

src/clj/fluree/db/json_ld/credential.cljc

src/clj/fluree/db/api.cljc

test/fluree/db/json_ld/credential_test.cljc

src/clj/fluree/db/query/api.cljc

src/clj/fluree/db/api.cljc

src/clj/fluree/db/json_ld/credential.cljc

src/clj/fluree/db/query/api.cljc

src/clj/fluree/db/api.cljc

bplatz

LGTM!

JaceRockman marked this pull request as ready for review June 12, 2024 19:53

JaceRockman requested a review from a team July 1, 2024 20:43

dpetran reviewed Jul 5, 2024

View reviewed changes

src/clj/fluree/db/api/query.cljc Outdated Show resolved Hide resolved

JaceRockman force-pushed the feature/sparql-query-policy-handling branch from 23c1bfa to 76ce505 Compare July 9, 2024 20:32

dpetran reviewed Jul 9, 2024

View reviewed changes

src/clj/fluree/db/query/api.cljc Outdated Show resolved Hide resolved

JaceRockman added 7 commits July 16, 2024 07:27

Add request-opts to the query opts

24447fe

This allows a role to be added to SPARQL queries.

Keep did or role if it is already in the query opts

826dc0b

If credentials fail, use original query

45b97a6

Only insert role and did on sparql queries

cb553f1

merge back in fluree.db.api.query

947de91

Remove unused ns and fix broken ref in correct ns

7d13dbf

Verify sparql query credentials and fix cred/verify

ffddf05

JaceRockman force-pushed the feature/sparql-query-policy-handling branch from 1b5a4d6 to ffddf05 Compare July 16, 2024 14:41

JaceRockman and others added 3 commits July 16, 2024 07:42

Revert formatting change

25edb32

Fix JWS verification for SPARQL queries

836fbe4

Also adds tests for this behavior

Merge branch 'main' into feature/sparql-query-policy-handling

a2647bf

dpetran reviewed Jul 17, 2024

View reviewed changes

src/clj/fluree/db/json_ld/credential.cljc Outdated Show resolved Hide resolved

dpetran reviewed Jul 17, 2024

View reviewed changes

src/clj/fluree/db/api.cljc Outdated Show resolved Hide resolved

dpetran reviewed Jul 17, 2024

View reviewed changes

test/fluree/db/json_ld/credential_test.cljc Outdated Show resolved Hide resolved

Fix credential-query-connection and add tests

2ee453d

dpetran reviewed Jul 17, 2024

View reviewed changes

src/clj/fluree/db/query/api.cljc Outdated Show resolved Hide resolved

dpetran reviewed Jul 17, 2024

View reviewed changes

src/clj/fluree/db/query/api.cljc Outdated Show resolved Hide resolved

JaceRockman and others added 4 commits July 18, 2024 08:33

Change request-opts to opts

9338f20

Remove unnecessary merge of :role and :did into fql

f6e4b00

Merge branch 'main' into feature/sparql-query-policy-handling

2094a01

Remove unnecessary destructuring of :role and :did

9682f14

JaceRockman mentioned this pull request Jul 19, 2024

Fix sparql query-credential APIs #843

Closed

JaceRockman added 3 commits July 19, 2024 07:52

Remove unnecessary logic for default-allow?

abee1be

Fix reference to credential-fql

9a8ed5f

Pull in default-allow? from opts in restrict-db

b36fb89

JaceRockman changed the title ~~Add request-opts to the query opts~~ Include opts in SPARQL queries Jul 19, 2024