Conversation
First we extract whatever context the user supplied, then we clobber it to expand our top-level document. We still have to jump through some hoops to remove the fluree context if it is supplied, but we won't have to do that anymore once we remove the default context.
Merged
zonotope
reviewed
Nov 14, 2023
| (contains? txn "@context")) | ||
| (->> (get txn "@context" (:context txn)) | ||
| (util/sequential) | ||
| (remove #{"https://ns.flur.ee"})))] |
Contributor
There was a problem hiding this comment.
what happens if the user also supplies the fluree context?
Contributor
Author
There was a problem hiding this comment.
We remove it. This is the status quo, though, and this commit doesn't change it. Once we properly remove default context this hack will no longer be necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/fluree/core/issues/54
Users no longer need to supply the fluree context in their transactions, unless they are wrapping them in a verifiable credential.