Add :remote conn type to connect to fluree/server#558
Merged
Conversation
zonotope
approved these changes
Aug 17, 2023
src/fluree/db/conn/remote.cljc
Outdated
|
|
||
| conn-proto/iConnection | ||
| (-close [_] | ||
| (log/info "Closing memory connection" id) |
Contributor
There was a problem hiding this comment.
I think this should be "Closing remote connection"
src/fluree/db/conn/remote.cljc
Outdated
| (storage/resolve-index-node conn node | ||
| (fn [] (conn-cache/lru-evict lru-cache-atom cache-key)))))))) | ||
|
|
||
| #?@(:clj |
Contributor
There was a problem hiding this comment.
I think we can just not implement the protocol here instead of implementing it and throwing an unsupported exception on the only method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This for #431 this adds a
:remoteconn type that takes a list offluree/serveraddresses and can execute queries against a remote server network.This adds core library support, so it can be used in any app using the library, or it is also used by fluree/server to establish a server as an edge query-server.
This PR does not contain the message broadcasting (auto-updating remote dbs), which will be in a separate PR to keep things slim.