Skip to content

Conversation

@TrafalgarZZZ
Copy link
Member

Ⅰ. Describe what this PR does

  • Create a common helper template for syncScheduleInfoNodeExcludeSelector env
  • Update all runtime controllers to use the new helper template
  • This change improves code reusability and maintainability across different runtime controllers

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.96%. Comparing base (73d2cf2) to head (39f05a4).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5300   +/-   ##
=======================================
  Coverage   56.96%   56.96%           
=======================================
  Files         442      442           
  Lines       30529    30529           
=======================================
  Hits        17390    17390           
  Misses      11523    11523           
  Partials     1616     1616           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…er template

- Create a common helper template for setting FLUID_SCHEDULE_INFO_EXCLUDE_NODE_SELECTOR
- Update all runtime controller YAML files to use the new helper template
- Reduce duplication and improve maintainability of the node selector configuration

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ TrafalgarZZZ force-pushed the refactor/helper_func_schedule_info_node_exclude_selector branch from f8f1959 to 39f05a4 Compare October 28, 2025 07:01
@TrafalgarZZZ TrafalgarZZZ requested a review from cheyang October 28, 2025 07:01
@sonarqubecloud
Copy link

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@TrafalgarZZZ TrafalgarZZZ merged commit 6533239 into fluid-cloudnative:master Oct 28, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants