Skip to content

refactor: make fuse sidecar mutators function-level composable #5293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluid-e2e-bot merged 3 commits into from
Oct 22, 2025
Merged

refactor: make fuse sidecar mutators function-level composable #5293

fluid-e2e-bot merged 3 commits into from
Oct 22, 2025

Conversation

@TrafalgarZZZ
Copy link
Member

@TrafalgarZZZ TrafalgarZZZ commented Oct 22, 2025

Ⅰ. Describe what this PR does

introduce mutatorHelper to organize PodSpec mutation logic

  • Extract common mutation logic into mutatorHelper struct
  • Define helper functions for each step of the mutation process
  • Update DefaultMutator and UnprivilegedMutator to use the new mutatorHelper
  • Remove redundant code and simplify mutation logic

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@TrafalgarZZZ
refactor(mutator): introduce mutatorHelper to organize PodSpec mutati…
54ef594 
…on logic

- Extract common mutation logic into mutatorHelper struct
- Define helper functions for each step of the mutation process
- Update DefaultMutator and UnprivilegedMutator to use the new mutatorHelper
- Remove redundant code and simplify mutation logic

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
refactor(inject): improve error handling in mutator helper
53cf7eb 
- Add informative error messages for each mutation step
- Wrap original errors with context information (namespace and name)

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
Add unit tests for mutating Pods mounting multiple Fluid PVCs
b3e1ade 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 22, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
7.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Oct 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 74.19355% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.96%. Comparing base (6854011) to head (b3e1ade).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...application/inject/fuse/mutator/mutator_default.go 78.08% 9 Missing and 7 partials ⚠️
.../application/inject/fuse/mutator/mutator_helper.go 25.00% 10 Missing and 5 partials ⚠️
...cation/inject/fuse/mutator/mutator_unprivileged.go 96.77% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5293      +/-   ##
==========================================
- Coverage   56.97%   56.96%   -0.01%     
==========================================
  Files         441      442       +1     
  Lines       30512    30476      -36     
==========================================
- Hits        17383    17361      -22     
+ Misses      11514    11504      -10     
+ Partials     1615     1611       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cheyang
cheyang approved these changes Oct 22, 2025
View reviewed changes
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Oct 22, 2025
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 9b73834 into fluid-cloudnative:master Oct 22, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TrafalgarZZZ @cheyang