Skip to content

feat: skip syncing schedule info for specified nodes #5285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cheyang merged 3 commits into from
Oct 18, 2025
Merged

feat: skip syncing schedule info for specified nodes #5285

cheyang merged 3 commits into from
Oct 18, 2025

Conversation

@TrafalgarZZZ
Copy link
Member

@TrafalgarZZZ TrafalgarZZZ commented Oct 17, 2025

Ⅰ. Describe what this PR does

Introduces nodeExcludeSelector to avoid syncing schedule info to nodes that match the nodeSelector. This is a useful feature when there are nodes virtualized by virtual-kubelet. Schedule info indicates which nodes have cache worker pods running on them. But users may want to skip syncing schedule info to virtual nodes.

# Fluid helm values.yaml
# syncScheduleInfoNodeExcludeSelector is used to exclude nodes that should be skipped when syncing schedule info
# e.g. syncScheduleInfoNodeExcludeSelector: "mynode=dev,type=virtual-kubelet"
syncScheduleInfoNodeExcludeSelector: "type=virtual-kubelet"

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@TrafalgarZZZ
feat: support specifying nodeExcludeSelector
6d9bf0d 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
Add FLUID_SCHEDULE_INFO_EXCLUDE_NODE_SELECTOR env variable t o all ru…
4667500 
…ntime controllers

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Oct 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Oct 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 45.83333% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.98%. Comparing base (3a92e49) to head (37c98c0).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/utils/dataset/lifecycle/node.go 45.83% 8 Missing and 5 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5285   +/-   ##
=======================================
  Coverage   56.97%   56.98%           
=======================================
  Files         441      441           
  Lines       30488    30512   +24     
=======================================
+ Hits        17372    17386   +14     
- Misses      11506    11512    +6     
- Partials     1610     1614    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TrafalgarZZZ
Refactor FLUID_SCHEDULE_INFO_EXCLUDE_NODE_SELECTOR to a common env co…
37c98c0 
…nstant

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ TrafalgarZZZ marked this pull request as ready for review October 17, 2025 09:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 17, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cheyang
cheyang approved these changes Oct 18, 2025
View reviewed changes
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Oct 18, 2025
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Oct 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 790c169 into fluid-cloudnative:master Oct 18, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TrafalgarZZZ @cheyang