-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add 3fs addon samples #5282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3fs addon samples #5282
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5282 +/- ##
==========================================
- Coverage 56.98% 56.97% -0.01%
==========================================
Files 441 441
Lines 30488 30488
==========================================
- Hits 17375 17372 -3
- Misses 11504 11506 +2
- Partials 1609 1610 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
addons/3fs/dev-guide/Dockerfile
Outdated
| @@ -0,0 +1,47 @@ | |||
| # Base image | |||
| FROM ubuntu:22.04 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please pin the docker image with sha256, please check the link: https://hub.docker.com/layers/library/ubuntu/22.04/images/sha256-4cb780d50443fc4463f1f9360c03ca46512e4fdd8fd97c5ce7e69c8758924575
Signed-off-by: pikabooboo <pikabooboo777@gmail.com>
|
RongGu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
| @@ -0,0 +1,47 @@ | |||
| # Base image | |||
| FROM ubuntu@sha256:09506232a8004baa32c47d68f1e5c307d648fdd59f5e7eaa42aaf87914100db3 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add '#Base image ubuntu:22.04'
RongGu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
cheyang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang, RongGu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |



Ⅰ. Describe what this PR does
3fs addon sample with initial Chinese development guide
Ⅱ. Does this pull request fix one issue?
fixes #5283
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews