enhance: set default syncRetryRateLimitDuration to 0s for thinruntime controller #5277
Conversation
… controller Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5277 +/- ##
=======================================
Coverage 56.70% 56.70%
=======================================
Files 440 440
Lines 30369 30369
=======================================
Hits 17220 17220
Misses 11537 11537
Partials 1612 1612 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Syspretor The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
syncRetryRateLimitDurationis used to avoid frequent status update when fluid's runtime controllers interacts with cache engines (e.g. Alluxio, Jindo, etc.).syncRetryRateLimitDurationdefines the interval where runtime controllers can interact with the cache engine only once.Setting a smaller
syncRetryRateLimitDurationmeans more frequent updates and more interactions with the cache engine. That usually means runtime status (e.g. cached, cached percentage, etc.) might be synced in a more frequent way. However, largersyncRetryRateLimitDurationmeans some of the update events would be skipped.This PR sets
syncRetryRateLimitDurationof thinruntime controller to "0s". This is a safe change because ThinRuntime is not designed to have cache engine so no interaction would happen. Setting to0smakes ThinRuntime controller to reconcile all update events without skipping, and this is very important when using ThinRuntime with dynamic mount feature.Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews