-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: thinruntime support pod metadata #5276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: thinruntime support pod metadata #5276
Conversation
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
|
/test fluid-e2e |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5276 +/- ##
==========================================
+ Coverage 56.71% 56.97% +0.26%
==========================================
Files 440 441 +1
Lines 30369 30488 +119
==========================================
+ Hits 17223 17372 +149
+ Misses 11535 11506 -29
+ Partials 1611 1610 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@TrafalgarZZZ Please run |
| enabled: true | ||
| image: "" | ||
| imageTag: "" | ||
| imagePullPolicy: IfNotPresent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please increment the helm chart version to track the change.
Signed-off-by: TrafalgarZZZ <trafalgarz@outlook.com>
Signed-off-by: TrafalgarZZZ <trafalgarz@outlook.com>
|
cheyang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |



Ⅰ. Describe what this PR does
podMetadatafield in ThinRuntime and ThinRuntimeProfilepodMetadata.labelsandpodMetadata.annotationsto ThinRuntime FUSE pod's metadataⅡ. Does this pull request fix one issue?
NONE
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews