Skip to content

bugfix: fix frequent status update #5226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluid-e2e-bot merged 10 commits into from
Sep 12, 2025
Merged

bugfix: fix frequent status update #5226

fluid-e2e-bot merged 10 commits into from
Sep 12, 2025

Conversation

@TrafalgarZZZ
Copy link
Member

@TrafalgarZZZ TrafalgarZZZ commented Sep 10, 2025 •
edited
Loading

Ⅰ. Describe what this PR does

  • fix a typo in func CheckAndSyncFuseStatus (DesiredMasterNumberScheduled -> DesiredFuseNumberScheduled), which caused runtime status's oscillation
  • Remove some code to make logic simple: master/worker/fuse status will only be updated in CheckAndSyncXXXStatus

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@TrafalgarZZZ
bugfix: fix typo in CheckAndSyncFuseStatus
a60e559 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
minorfix for typo in ThinEngine.CheckAndUpdateRuntimeStatus
d96ca1c 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
Remove status update in AlluxioEngine.checkExistenceOfMaster
3f5d92b 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
avoid updating worker status when syncing worker replicas
dc1d2e8 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
refactor(master): avoid setting DesiredMasterNumberScheduled in engin…
a2e8021 
….SetupMaster

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
avoid updating runtime status in CheckAndUpdateRuntimeStatus
f626da5 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
fix unit tests for ctrl functions
40c8ab6 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
fix unit tests for runtime engines
1d092e0 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@codecov
Copy link

codecov bot commented Sep 10, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 63.93443% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.51%. Comparing base (22d8041) to head (7ecd5a0).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/utils/runtime_condition.go 0.00% 13 Missing ⚠️
pkg/ctrl/replicas.go 83.33% 2 Missing and 1 partial ⚠️
pkg/ddc/alluxio/health_check.go 33.33% 1 Missing and 1 partial ⚠️
pkg/ddc/jindocache/status.go 0.00% 2 Missing ⚠️
pkg/ddc/thin/status.go 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5226      +/-   ##
==========================================
- Coverage   55.57%   55.51%   -0.06%     
==========================================
  Files         443      443              
  Lines       30525    30382     -143     
==========================================
- Hits        16963    16867      -96     
+ Misses      12005    11962      -43     
+ Partials     1557     1553       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TrafalgarZZZ
Copy link
Member Author

TrafalgarZZZ commented Sep 10, 2025

/test fluid-e2e

@TrafalgarZZZ
Simplify scaling event message for event merging
b9e9041 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
cheyang
cheyang reviewed Sep 11, 2025
View reviewed changes
@cheyang
Copy link
Collaborator

cheyang commented Sep 11, 2025 •
edited
Loading

@TrafalgarZZZ Thank you for contributing high-quality refactor that significantly improves the codebase a lot. Only a small suggestion from me.

@TrafalgarZZZ
fix comments
7ecd5a0 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 12, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
33.2% Duplication on New Code

See analysis details on SonarQube Cloud

cheyang
cheyang approved these changes Sep 12, 2025
View reviewed changes
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Sep 12, 2025
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Sep 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 2244413 into fluid-cloudnative:master Sep 12, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TrafalgarZZZ @cheyang