Skip to content

Conversation

@Syspretor
Copy link
Collaborator

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #5205

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Syspretor Syspretor changed the title [WIP] fix missing some fields during juicefs runtime sync [WIP] fix unexpected overide some fields during juicefs runtime sync Sep 3, 2025
@Syspretor Syspretor changed the title [WIP] fix unexpected overide some fields during juicefs runtime sync [WIP] fix unexpected override some fields after updating juicefsruntime Sep 3, 2025
@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.27%. Comparing base (a42f1d8) to head (e23f677).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5216      +/-   ##
==========================================
- Coverage   55.77%   55.27%   -0.51%     
==========================================
  Files         413      414       +1     
  Lines       28087    27498     -589     
==========================================
- Hits        15666    15199     -467     
+ Misses      11006    10931      -75     
+ Partials     1415     1368      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Syspretor Syspretor force-pushed the fix/missing-fields-on-update branch 2 times, most recently from 915a66a to da400a1 Compare September 4, 2025 03:26
@Syspretor Syspretor force-pushed the fix/missing-fields-on-update branch from da400a1 to b52b48b Compare September 5, 2025 06:08
@Syspretor Syspretor force-pushed the fix/missing-fields-on-update branch from b52b48b to 0ed3d64 Compare September 5, 2025 07:50
@Syspretor Syspretor changed the title [WIP] fix unexpected override some fields after updating juicefsruntime fix unexpected override some fields after updating juicefsruntime Sep 5, 2025
@Syspretor Syspretor force-pushed the fix/missing-fields-on-update branch from 0ed3d64 to 830ddfe Compare September 5, 2025 09:29
Signed-off-by: 玖宇 <guotongyu.gty@alibaba-inc.com>
@Syspretor Syspretor force-pushed the fix/missing-fields-on-update branch from 830ddfe to e23f677 Compare September 5, 2025 09:37
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2025

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 5b1b9cd into fluid-cloudnative:master Sep 5, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Unexpected spec overriding when applying JuiceFSRuntime's spec

4 participants