Skip to content

refactor: ddc engine health check #5215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluid-e2e-bot merged 18 commits into from
Sep 5, 2025
Merged

refactor: ddc engine health check #5215

fluid-e2e-bot merged 18 commits into from
Sep 5, 2025

Conversation

@TrafalgarZZZ
Copy link
Member

@TrafalgarZZZ TrafalgarZZZ commented Sep 2, 2025

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@TrafalgarZZZ
update func UpdateRuntimeCondition
3ed003f 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
refactor engine.CheckWorkersReady
cd1be52 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
fix unit test & move worker related functions to workers.go
8188d2f 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ TrafalgarZZZ marked this pull request as draft September 2, 2025 04:06
@TrafalgarZZZ
fix unit tests
6243ccf 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
refactor engine.CheckMasterReady
6fcc5d4 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
fix unit tests
da05980 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
fix unit tests
20724ac 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@codecov
Copy link

codecov bot commented Sep 2, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 62.96296% with 170 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.92%. Comparing base (a42f1d8) to head (5977c5a).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/ctrl/worker.go 66.36% 28 Missing and 9 partials ⚠️
pkg/ddc/vineyard/health_check.go 32.25% 17 Missing and 4 partials ⚠️
pkg/ctrl/master.go 64.44% 13 Missing and 3 partials ⚠️
pkg/ddc/efc/health_check.go 51.61% 13 Missing and 2 partials ⚠️
pkg/ddc/juicefs/health_check.go 50.00% 11 Missing and 2 partials ⚠️
pkg/ddc/jindocache/health_check.go 61.29% 9 Missing and 3 partials ⚠️
pkg/ddc/thin/health_check.go 56.00% 9 Missing and 2 partials ⚠️
pkg/ddc/alluxio/health_check.go 67.74% 8 Missing and 2 partials ⚠️
pkg/utils/runtime_condition.go 0.00% 10 Missing ⚠️
pkg/ddc/alluxio/status.go 25.00% 8 Missing and 1 partial ⚠️
... and 7 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5215      +/-   ##
==========================================
- Coverage   55.77%   54.92%   -0.86%     
==========================================
  Files         413      443      +30     
  Lines       28087    30476    +2389     
==========================================
+ Hits        15666    16739    +1073     
- Misses      11006    12175    +1169     
- Partials     1415     1562     +147

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TrafalgarZZZ
refactor func checkFuseHealthy()
a841c78 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
refactor func checkFuseHealthy()
d0bff17 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
refactor func checkRuntimeHealthy
e9efaad 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
fix unit tests
5158aa7 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
Remove unused code
e01e59e 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
add unit tests for ctrl helper functions
74eeae3 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
add unit tests for ctrl helper functions
bbb7d6d 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
add unit tests for ctrl helper functions
bc9704e 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
Copy link
Member Author

TrafalgarZZZ commented Sep 4, 2025

/test fluid-e2e

@TrafalgarZZZ
fix codecov yml
c58afa8 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
Copy link
Member Author

TrafalgarZZZ commented Sep 4, 2025

/test fluid-e2e

@TrafalgarZZZ TrafalgarZZZ marked this pull request as ready for review September 4, 2025 10:04
@TrafalgarZZZ
Copy link
Member Author

TrafalgarZZZ commented Sep 4, 2025

/retest

cheyang
cheyang requested changes Sep 4, 2025
View reviewed changes
cheyang
cheyang requested changes Sep 4, 2025
View reviewed changes
@TrafalgarZZZ
fix "fail" to "failed"
5ddeb00 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
rename CheckAndUpdateXXXStatus to CheckAndSyncXXXStatus
5977c5a 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2025

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
43.7% Duplication on New Code

See analysis details on SonarQube Cloud

@TrafalgarZZZ
Copy link
Member Author

TrafalgarZZZ commented Sep 5, 2025

/test fluid-e2e

cheyang
cheyang approved these changes Sep 5, 2025
View reviewed changes
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Sep 5, 2025
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 5ba2b0c into fluid-cloudnative:master Sep 5, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TrafalgarZZZ @cheyang