Skip to content

fix volumes when no data in tierdstore #5206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cheyang merged 10 commits into from
Sep 3, 2025
Merged

fix volumes when no data in tierdstore #5206

cheyang merged 10 commits into from
Sep 3, 2025

Conversation

@zwwhdls
Copy link
Member

@zwwhdls zwwhdls commented Aug 21, 2025

Ⅰ. Describe what this PR does

  1. do not mount default cache-dir when cache-dir exists and no data in tierdstore
  2. fix mount option sync
  3. update mount image tag

Ⅱ. Does this pull request fix one issue?

None

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

zwwhdls added 3 commits August 21, 2025 12:53
@zwwhdls
juicefs: fix volumeMount when no data in tierdstore
fd117cf 
Signed-off-by: zwwhdls <zww@hdls.me>
@zwwhdls
juicefs: fix mount option sync
3fc0bbd 
Signed-off-by: zwwhdls <zww@hdls.me>
@zwwhdls
juicefs: update default image tag
070f974 
Signed-off-by: zwwhdls <zww@hdls.me>
cheyang
cheyang reviewed Aug 24, 2025
View reviewed changes
@zwwhdls
fix wrap error
fe7238f 
Signed-off-by: zwwhdls <zww@hdls.me>
@codecov
Copy link

codecov bot commented Aug 25, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 93.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.73%. Comparing base (8752fd6) to head (219f88c).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/ddc/juicefs/sync_runtime.go 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5206      +/-   ##
==========================================
+ Coverage   55.53%   55.73%   +0.19%     
==========================================
  Files         412      413       +1     
  Lines       27540    28113     +573     
==========================================
+ Hits        15295    15668     +373     
- Misses      10831    11027     +196     
- Partials     1414     1418       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cheyang
Copy link
Collaborator

cheyang commented Aug 26, 2025

@zwwhdls Please improve the code coverage. Thanks a lot.

zwwhdls added 2 commits August 27, 2025 10:48
@zwwhdls
more ut
a911c14 
Signed-off-by: zwwhdls <zww@hdls.me>
@zwwhdls
Merge branch 'master' of github.com:fluid-cloudnative/fluid into juic…
c7cc556 
…efs/fix_volume
@zwwhdls
Copy link
Member Author

zwwhdls commented Sep 1, 2025

@zwwhdls Please improve the code coverage. Thanks a lot.

done

TrafalgarZZZ
TrafalgarZZZ reviewed Sep 2, 2025
View reviewed changes
@zwwhdls
fix review
063c96a 
Signed-off-by: zwwhdls <zww@hdls.me>
@zwwhdls
do not mount tierdstore when cache-dir is set
d2452be 
Signed-off-by: zwwhdls <zww@hdls.me>
@zwwhdls
do not mount tierdstore when cache-dir is set
1be905c 
Signed-off-by: zwwhdls <zww@hdls.me>
@zwwhdls
fix ut
219f88c 
Signed-off-by: zwwhdls <zww@hdls.me>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2025

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
21.6% Duplication on New Code

See analysis details on SonarQube Cloud

@TrafalgarZZZ
Copy link
Member

TrafalgarZZZ commented Sep 3, 2025

/lgtm

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Sep 3, 2025
cheyang
cheyang approved these changes Sep 3, 2025
View reviewed changes
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 73e92f8 into fluid-cloudnative:master Sep 3, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrafalgarZZZ TrafalgarZZZ TrafalgarZZZ left review comments

@cheyang cheyang cheyang approved these changes

@Syspretor Syspretor Awaiting requested review from Syspretor

Assignees

@cheyang cheyang

@TrafalgarZZZ TrafalgarZZZ

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zwwhdls @cheyang @TrafalgarZZZ