Enhancement: support to retry by apireader client in webhook #5177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
6a57442 to
71da6a8
Compare
cheyang
requested changes
Jul 17, 2025
cheyang
reviewed
Jul 23, 2025
97bad3b to
5585476
Compare
…webhook Signed-off-by: 玖宇 <guotongyu.gty@alibaba-inc.com>
5585476 to
180efd2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current webhook design, to avoid generating excessive API requests to the apiserver, a
cacheClientimplementation is used in the webhook. However, under heavy load on the apiserver or communication link issues, this can lead to delays in resource status updates within the webhook, causing problems such as state verification failures or resource retrieval failures. This PR introduces new error types for errors returned during the mutation process. For errors of this type, the webhook will use a direct client connection to the apiserver for retries.