Skip to content

fix jindoruntime support dls prefix url #5158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cheyang merged 1 commit into from
Jul 14, 2025
Merged

fix jindoruntime support dls prefix url #5158

cheyang merged 1 commit into from
Jul 14, 2025

Conversation

@arwangasdaf
Copy link
Contributor

@arwangasdaf arwangasdaf commented Jun 30, 2025

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jun 30, 2025

Hi @arwangasdaf. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cheyang
Copy link
Collaborator

cheyang commented Jun 30, 2025

@arwangasdaf Please fix DCO issue by following https://github.com/fluid-cloudnative/fluid/pull/5158/checks?check_run_id=45020965973

@cheyang cheyang requested a review from frankleaf June 30, 2025 10:50
@frankleaf
fix jindoruntime support dls prefix url
38a24ec 
Signed-off-by: frankleaf <frank.wt@alibaba-inc.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 30, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
77.3% Duplication on New Code

See analysis details on SonarQube Cloud

cheyang
cheyang approved these changes Jul 13, 2025
View reviewed changes
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Jul 13, 2025
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jul 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 484cc04 into fluid-cloudnative:master Jul 14, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

@frankleaf frankleaf Awaiting requested review from frankleaf

Assignees

@cheyang cheyang

Labels

approved lgtm needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arwangasdaf @cheyang @frankleaf