-
Notifications
You must be signed in to change notification settings - Fork 1.1k
This PR is to add comments to generateGooseFSValueFile in pkg\ddc\goosefs\master_internal.go #5113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @biluohq. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
cheyang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
…ternal.go Signed-off-by: biluohq <biluo.hq@qq.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5113 +/- ##
==========================================
- Coverage 55.52% 55.51% -0.01%
==========================================
Files 443 443
Lines 30382 30382
==========================================
- Hits 16870 16867 -3
- Misses 11960 11962 +2
- Partials 1552 1553 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cheyang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |



Ⅰ. Describe what this PR does
add comments to generateGooseFSValueFile in pkg\ddc\goosefs\master_internal.go
Ⅱ. Does this pull request fix one issue?
fixes #5112
Ⅲ. Special notes for reviews
nothing