Skip to content

This PR is to add comments to newTestJindoEngine in pkg\ddc\jindo\delete_volume_test.go. #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluid-e2e-bot merged 3 commits into from
Sep 15, 2025
Merged

This PR is to add comments to newTestJindoEngine in pkg\ddc\jindo\delete_volume_test.go. #5097

fluid-e2e-bot merged 3 commits into from
Sep 15, 2025

Conversation

@Zhangggggggggg
Copy link
Contributor

@Zhangggggggggg Zhangggggggggg commented Jun 12, 2025

I. Describe what this PR does
Add comments to newTestJindoEngine in pkg\ddc\jindo\delete_volume_test.go.
II. Does this pull request fix one issue?
fixes #5096
III. Special notes for reviews

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jun 12, 2025

Hi @Zhangggggggggg. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 12, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
58.8% Duplication on New Code

See analysis details on SonarQube Cloud

@Zhangggggggggg @cheyang
Add comments to TestShouldCheckUFS in pkg/ddc/alluxio/ufs_test.go.
ef26dc3 
Signed-off-by: Zhangggggggggg <1253360905@qq.com>
@Zhangggggggggg @cheyang
Add comments to newTestJindoEngine in pkg/ddc/jindo/delete_volume_tes…
ace6202 
…t.go.

Signed-off-by: Zhangggggggggg <1253360905@qq.com>
@cheyang cheyang force-pushed the new-branch-for-commit branch from 6df275c to ace6202 Compare September 15, 2025 07:36
@cheyang
Update comments of function newTestJindoEngine
dc35b58 
Signed-off-by: cheyang <cheyang@163.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cheyang
cheyang approved these changes Sep 15, 2025
View reviewed changes
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Sep 15, 2025
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Sep 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit f8fa5c3 into fluid-cloudnative:master Sep 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add comments to newTestJindoEngine in pkg\ddc\jindo\delete_volume_test.go.

2 participants

@Zhangggggggggg @cheyang