Skip to content

Conversation

@Zhican1229
Copy link
Contributor

Ⅰ. Describe what this PR does

Adds descriptive comments to the TestPatchDatasetStatus function in pkg/ddc/alluxio/cache_test.go.
The comment explains the purpose and logic of the unit test, which validates the calculation of cached data percentage in a dataset.

Ⅱ. Does this pull request fix one issue?

fixes #5057

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

No new test cases are added.
This PR only adds comments to an existing unit test function. The logic and behavior of the code remain unchanged.

Ⅳ. Describe how to verify it

Since this PR only adds comments, no additional verification is required.

Ⅴ. Special notes for reviews

This is a documentation-only change.

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jun 4, 2025

Hi @Zhican1229. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2025

Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run "make fmt" to verify gofmt

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2025

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Aug 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang, TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [TrafalgarZZZ,cheyang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit a6c6343 into fluid-cloudnative:master Aug 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to TestPatchDatasetStatus(t *testing.T) in pkg\ddc\alluxio\cache_test.go.

3 participants