-
Notifications
You must be signed in to change notification settings - Fork 1.1k
This PR is to add comments to TestPatchDatasetStatus in pkg\ddc\alluxio\cache_test.go. #5058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Zhican1229 <fgrhyh@qq.com>
|
Hi @Zhican1229. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
TrafalgarZZZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
cheyang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run "make fmt" to verify gofmt
Signed-off-by: cheyang <cheyang@163.com>
|
cheyang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang, TrafalgarZZZ The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |



Ⅰ. Describe what this PR does
Adds descriptive comments to the TestPatchDatasetStatus function in pkg/ddc/alluxio/cache_test.go.
The comment explains the purpose and logic of the unit test, which validates the calculation of cached data percentage in a dataset.
Ⅱ. Does this pull request fix one issue?
fixes #5057
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
No new test cases are added.
This PR only adds comments to an existing unit test function. The logic and behavior of the code remain unchanged.
Ⅳ. Describe how to verify it
Since this PR only adds comments, no additional verification is required.
Ⅴ. Special notes for reviews
This is a documentation-only change.