Skip to content

bugfix: fix log panic when webhook running in development mode #4470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluid-e2e-bot merged 1 commit into from
Jan 14, 2025
Merged

bugfix: fix log panic when webhook running in development mode #4470

fluid-e2e-bot merged 1 commit into from
Jan 14, 2025

Conversation

@TrafalgarZZZ
Copy link
Member

@TrafalgarZZZ TrafalgarZZZ commented Jan 13, 2025

Ⅰ. Describe what this PR does

This is a bugfix for Fluid webhooks running in development mode which might panic when using the FuseSidecar webhook plugin.

To reproduce the issue:

  1. create any dataset & runtime
  2. create pod using FuseSidecar plugin
  3. found webhook panics with the following message
2025/01/13 14:57:45 http: panic serving 192.168.4.149:37462: odd number of arguments passed as key-value pairs for logging
goroutine 104 [running]:
net/http.(*conn).serve.func1()
        /usr/local/go/src/net/http/server.go:1868 +0x13d
panic({0x21fce40?, 0xc00018b390?})
        /usr/local/go/src/runtime/panic.go:920 +0x290
github.com/fluid-cloudnative/fluid/vendor/go.uber.org/zap/zapcore.CheckWriteAction.OnWrite(0x2, 0xc0006f6000, {0x0, 0xc0005ed800, 0xbda})
        /go/src/github.com/fluid-cloudnative/fluid/vendor/go.uber.org/zap/zapcore/entry.go:196 +0x99
github.com/fluid-cloudnative/fluid/vendor/go.uber.org/zap/zapcore.(*CheckedEntry).Write(0xc0006f6000, {0xc000636880, 0x1, 0x1})
        /go/src/github.com/fluid-cloudnative/fluid/vendor/go.uber.org/zap/zapcore/entry.go:262 +0x613
github.com/fluid-cloudnative/fluid/vendor/go.uber.org/zap.(*Logger).DPanic(0xc000684b80, {0x253d31a, 0x3d}, {0xc000636880, 0x1, 0x1})
        /go/src/github.com/fluid-cloudnative/fluid/vendor/go.uber.org/zap/logger.go:275 +0x66
github.com/fluid-cloudnative/fluid/vendor/github.com/go-logr/zapr.(*zapLogger).handleFields(0xc000588ea0, 0x1, {0xc00018b320, 0x1, 0x1}, {0x0, 0x0, 0x0})
        /go/src/github.com/fluid-cloudnative/fluid/vendor/github.com/go-logr/zapr/zapr.go:147 +0xd05
github.com/fluid-cloudnative/fluid/vendor/github.com/go-logr/zapr.(*zapLogger).Info(0xc000588ea0, 0x1, {0x2511e19, 0x2a}, {0xc00018b320, 0x1, 0x1})
        /go/src/github.com/fluid-cloudnative/fluid/vendor/github.com/go-logr/zapr/zapr.go:201 +0xc9
github.com/fluid-cloudnative/fluid/vendor/github.com/go-logr/logr.Logger.Info({{0x26cc228, 0xc000588ea0}, 0x1}, {0x2511e19, 0x2a}, {0xc00018b320, 0x1, 0x1})
        /go/src/github.com/fluid-cloudnative/fluid/vendor/github.com/go-logr/logr/logr.go:280 +0x171
github.com/fluid-cloudnative/fluid/pkg/application/inject/fuse.(*Injector).inject(0xc000588f30, {0x26b61b8, 0xc0005ff200}, 0xc000655380)
        /go/src/github.com/fluid-cloudnative/fluid/pkg/application/inject/fuse/injector.go:182 +0x179b
github.com/fluid-cloudnative/fluid/pkg/application/inject/fuse.(*Injector).Inject(0xc000588f30, {0x26b61b8, 0xc0005ff200}, 0xc000655380)
        /go/src/github.com/fluid-cloudnative/fluid/pkg/application/inject/fuse/injector.go:237 +0x74
github.com/fluid-cloudnative/fluid/pkg/application/inject/fuse.(*Injector).InjectPod(0xc000588f30, 0xc0005ff200, 0xc000655380)
        /go/src/github.com/fluid-cloudnative/fluid/pkg/application/inject/fuse/injector.go:55 +0x7f
github.com/fluid-cloudnative/fluid/pkg/webhook/plugins/fusesidecar.(*FuseSidecar).Mutate(0xc0000d5d40, 0xc0005ff200, 0xc000655380)
        /go/src/github.com/fluid-cloudnative/fluid/pkg/webhook/plugins/fusesidecar/fuse_sidecar.go:73 +0x3ed
github.com/fluid-cloudnative/fluid/pkg/webhook/handler/mutating.(*FluidMutatingHandler).MutatePod(0xc00019c840, 0xc0005ff200)
        /go/src/github.com/fluid-cloudnative/fluid/pkg/webhook/handler/mutating/mutating_handler.go:155 +0xb2a
github.com/fluid-cloudnative/fluid/pkg/webhook/handler/mutating.(*FluidMutatingHandler).Handle(_, {_, _}, {{{0xc000043740, 0x24}, {{0x0, 0x0}, {0xc00090d3d0, 0x2}, {0xc00090d3d2, ...}}, ...}})
        /go/src/github.com/fluid-cloudnative/fluid/pkg/webhook/handler/mutating/mutating_handler.go:97 +0xe56
github.com/fluid-cloudnative/fluid/vendor/sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Webhook).Handle(_, {_, _}, {{{0xc000043740, 0x24}, {{0x0, 0x0}, {0xc00090d3d0, 0x2}, {0xc00090d3d2, ...}}, ...}})

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@TrafalgarZZZ
bugfix: fix log panic when webhook running in development mode
e2f011a 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 13, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cheyang
cheyang approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Jan 14, 2025
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit a537a5f into fluid-cloudnative:master Jan 14, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TrafalgarZZZ @cheyang