Enhancement: Unify the implementation of label concatenation and support labels with over limit length #4466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
3a8daff to
86bdb4c
Compare
d667065 to
58ce2ea
Compare
cheyang
requested changes
Jan 9, 2025
Collaborator
cheyang
left a comment
There was a problem hiding this comment.
I suggest tagging the uuid label in the dataset when it's initializing.
pkg/utils/hash.go
Outdated
| return | ||
| } | ||
|
|
||
| namespacedNameHashValue, err := ComputeFullNamespacedNameHashValue(namespace, name) |
Collaborator
There was a problem hiding this comment.
Please use maxGeneratedNameLength and randomLength to improve readability.
05eeb86 to
542b7e9
Compare
a5f2b4e to
3c8f644
Compare
Collaborator
Author
|
/test fluid-e2e |
a54d344 to
137ee71
Compare
cheyang
requested changes
Jan 22, 2025
137ee71 to
6fdcbde
Compare
Collaborator
|
/test fluid-e2e |
…ifferent Runtimes, and support labels with over limit length Signed-off-by: jiuyu <guotongyu.gty@alibaba-inc.com> * Feature: add datasetIdLabel to all the resources created by fluid Signed-off-by: jiuyu <guotongyu.gty@alibaba-inc.com>
6fdcbde to
7e5401a
Compare
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4382
Related proposal: https://github.com/fluid-cloudnative/community/blob/master/proposals/label/v1.0.5_label_chore_zh.md