Skip to content

Conversation

@cheyang
Copy link
Collaborator

@cheyang cheyang commented Nov 2, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: cheyang <cheyang@163.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2024

@codecov
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.25%. Comparing base (e1cac4d) to head (f63c2a3).
Report is 32 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4386      +/-   ##
==========================================
- Coverage   58.35%   58.25%   -0.10%     
==========================================
  Files         563      565       +2     
  Lines       31291    30952     -339     
==========================================
- Hits        18260    18032     -228     
+ Misses      10782    10729      -53     
+ Partials     2249     2191      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yangyuliufeng yangyuliufeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Nov 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yangyuliufeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangyuliufeng yangyuliufeng merged commit 98a1946 into fluid-cloudnative:master Nov 2, 2024
@cheyang cheyang deleted the docker_build_241102 branch January 17, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants