Fix code scanning alert - Prefer COPY over ADD #4378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
cheyang
requested changes
Oct 30, 2024
addons/nfs/docker/Dockerfile
Outdated
| COPY ./fluid_config_init.py / | ||
| COPY ./entrypoint.sh /usr/local/bin | ||
| COPY --from=BUILD /src/fuse/fuse-nfs /bin/fuse-nfs | ||
| CMD ["/usr/local/bin/entrypoint.sh"] |
Collaborator
There was a problem hiding this comment.
Please add return of line.
Collaborator
|
@omerap12 Please don't change vendor/github.com/nxadm/tail/Dockerfile |
Member
Author
Yeap, sorry :( |
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Fix code scanning alert - Replace
ADDin Dockerfiles toCOPYⅡ. Does this pull request fix one issue?
fixes #4354
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews