Skip to content

Conversation

@Syspretor
Copy link
Collaborator

Ⅰ. Describe what this PR does

fix some issues of helm chart

  1. imagePullSecret is supported in deploying thinRuntimeController & crd-Uprader
  2. unify the interface of resource declaration
  3. fix duplicated imagePullSecret configuration in juicefs-dataloader-conJob

Signed-off-by: jiuyu <guotongyu.gty@alibaba-inc.com>
@Syspretor Syspretor force-pushed the fix/fix-some-issues-of-helm-chart branch from 2bc3940 to 8c0d3df Compare October 22, 2024 02:18
@sonarqubecloud
Copy link

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit a095217 into fluid-cloudnative:master Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants