Skip to content

Fix general grammar mistakes #4368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ankur0904 wants to merge 2 commits into from
Closed

Fix general grammar mistakes #4368

ankur0904 wants to merge 2 commits into from

Conversation

@ankur0904
Copy link
Contributor

@ankur0904 ankur0904 commented Oct 20, 2024

Nominated by one of the maintainers or TOC members by open a community issue -> Nominated by one of the maintainers or TOC members by opening a community issue

@cheyang
Copy link
Collaborator

cheyang commented Oct 21, 2024

@ankur0904 Thank you for your contribution! Please fix DCO issue by following https://github.com/fluid-cloudnative/fluid/pull/4368/checks?check_run_id=31786514847

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zwwhdls for approval by writing /assign @zwwhdls in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ankur0904
Copy link
Contributor Author

ankur0904 commented Oct 21, 2024

@cheyang
how to fix DCO?

I have run these commands locally

  • git rebase HEAD~1 --signoff
  • git push --force-with-lease origin fix-grammar-error

but nothing happened!

@ankur0904 ankur0904 mentioned this pull request Oct 23, 2024
Merged
@ankur0904 ankur0904 closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ankur0904 @cheyang