Skip to content

Conversation

@Syspretor
Copy link
Collaborator

In this PR, we have added a multi-level definition of imagePullSecrets to the JindoRuntime custom resource definitions (CRDs).

Global level, under spec
Component level
a. Worker level, under spec.worker
b. Fuser level, under spec.fuse
c. Master lever, under spec.master

When imagePullSecrets are defined in both two level the JindoRuntime CRs, the priority is as follows:

JindoRuntime.spec.$component.imagePullSecrets > JindoRuntime.spec.imagePullSecrets

For example, secret-worker will be used in setup worker, secret-master will be used in setup master and secret-global will be used in setup fuse

apiVersion: data.fluid.io/v1alpha1
kind: JindoRuntime
metadata:
  name: demo
spec:
  imagePullSecrets:
  - name: secret-global
  worker:
    imagePullSecrets:
    - name: secret-worker
  master:
    imagePullSecrets:
    - name: secret-master
  replicas: 1
  tieredstore:
    levels:
    - mediumtype: MEM
      path: /dev/shm
      quota: 4Gi
      high: "0.95"
      low: "0.7"

@Syspretor Syspretor force-pushed the feature/support-imagePullSecrets-in-JindoRuntime branch 4 times, most recently from 37735bd to aecb555 Compare October 10, 2024 07:50
Signed-off-by: jiuyu <guotongyu.gty@alibaba-inc.com>
@Syspretor Syspretor force-pushed the feature/support-imagePullSecrets-in-JindoRuntime branch from aecb555 to c25ae28 Compare October 10, 2024 08:13
@sonarqubecloud
Copy link

@cheyang
Copy link
Collaborator

cheyang commented Oct 11, 2024

/test fluid-e2e

@cheyang
Copy link
Collaborator

cheyang commented Oct 11, 2024

Thanks for the contributions! The fix looks good. I suggest adding E2E test case to avoid regressions.

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 49dd011 into fluid-cloudnative:master Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants