Skip to content

Conversation

@Syspretor
Copy link
Collaborator

@Syspretor Syspretor commented Oct 10, 2024

ThinRuntime, as provided by Fluid, allows users to customize the storage system definition. In many scenarios, users build their own ThinRuntime images, so the configuration of imagePullSecrets is essential. This is because private images need to be pulled when the Fuse mountPod is started.

In this PR, we have added a multi-level definition of imagePullSecrets to the ThinRuntime and ThinRuntimeProfile custom resource definitions (CRDs).

Global level, under spec
Component level
a. Worker level, under spec.worker
b. Fuser level, under spec.fuse

When imagePullSecrets are defined in both the ThinRuntime and ThinRuntimeProfile CRs, the priority is as follows:

thinRuntime.spec.fuse.imagePullSecrets > thinRuntime.spec.imagePullSecrets > thinRuntimeProfile.spec.fuse.imagePullSecrets > thinRuntimeProfile.spec.imagePullSecrets

For example, secret-worker will be used in setup worker and secret-global will be used in setup fuse

apiVersion: data.fluid.io/v1alpha1
kind: ThinRuntime
metadata:
    name: demo
spec:
    imagePullSecrets: 
    - name: secret-global
    worker:
         imagePullSecrets: 
         - name: secret-worker
    fuse:

@Syspretor Syspretor force-pushed the feature/support-image-pull-secret-in-thinruntime branch 2 times, most recently from bc5306b to 4c157b9 Compare October 10, 2024 06:07
@sonarqubecloud
Copy link

Signed-off-by: jiuyu <guotongyu.gty@alibaba-inc.com>
@Syspretor Syspretor force-pushed the feature/support-image-pull-secret-in-thinruntime branch from 4c157b9 to 8bf0ec6 Compare October 10, 2024 06:35
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 6604955 into fluid-cloudnative:master Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants