Skip to content

enhance: optimize fluid helm chart #4319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluid-e2e-bot merged 4 commits into from
Sep 15, 2024
Merged

enhance: optimize fluid helm chart #4319

fluid-e2e-bot merged 4 commits into from
Sep 15, 2024

Conversation

@TrafalgarZZZ
Copy link
Member

@TrafalgarZZZ TrafalgarZZZ commented Sep 14, 2024

Ⅰ. Describe what this PR does

  • Add root context to imageTransform helm function
  • Allow configurable resources for each runtime controller
  • Extract "fluid.controlplane.affinity" helm function for all controlplane components.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@TrafalgarZZZ
Add root context to image transform helm helper function
96a5e27 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
optimize helm template file format
fed47e8 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
Add configurable resources for each controller in helm values
904cfec 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
refactor helm function"fluid.controlplane.affinity"
4b56c8c 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 14, 2024

Quality Gate Passed Quality Gate passed

Issues
60 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 14, 2024
View reviewed changes
charts/fluid/fluid/templates/controller/alluxioruntime_controller.yaml
#hostNetwork: true
containers:
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.runtime.alluxio.controller.imagePrefix .Values.runtime.alluxio.controller.imageName .Values.runtime.alluxio.controller.imageTag) }}
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.runtime.alluxio.controller.imagePrefix .Values.runtime.alluxio.controller.imageName .Values.runtime.alluxio.controller.imageTag . ) }}

Check warning

Code scanning / SonarCloud

Storage limits should be enforced

<!--SONAR_ISSUE_KEY:AZHv_MWkREFgCmEnHMZ0-->Specify a storage limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZHv_MWkREFgCmEnHMZ0&open=AZHv_MWkREFgCmEnHMZ0&pullRequest=4319">SonarCloud</a></p>
charts/fluid/fluid/templates/controller/alluxioruntime_controller.yaml
#hostNetwork: true
containers:
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.runtime.alluxio.controller.imagePrefix .Values.runtime.alluxio.controller.imageName .Values.runtime.alluxio.controller.imageTag) }}
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.runtime.alluxio.controller.imagePrefix .Values.runtime.alluxio.controller.imageName .Values.runtime.alluxio.controller.imageTag . ) }}

Check warning

Code scanning / SonarCloud

Memory limits should be enforced

<!--SONAR_ISSUE_KEY:AZHv_MWkREFgCmEnHMZz-->Specify a memory limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZHv_MWkREFgCmEnHMZz&open=AZHv_MWkREFgCmEnHMZz&pullRequest=4319">SonarCloud</a></p>
charts/fluid/fluid/templates/controller/dataset_controller.yaml
#hostNetwork: true
containers:
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.dataset.controller.imagePrefix .Values.dataset.controller.imageName .Values.dataset.controller.imageTag) }}
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.dataset.controller.imagePrefix .Values.dataset.controller.imageName .Values.dataset.controller.imageTag . ) }}

Check warning

Code scanning / SonarCloud

Memory limits should be enforced

<!--SONAR_ISSUE_KEY:AZHv_MWZREFgCmEnHMZt-->Specify a memory limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZHv_MWZREFgCmEnHMZt&open=AZHv_MWZREFgCmEnHMZt&pullRequest=4319">SonarCloud</a></p>
charts/fluid/fluid/templates/controller/dataset_controller.yaml
#hostNetwork: true
containers:
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.dataset.controller.imagePrefix .Values.dataset.controller.imageName .Values.dataset.controller.imageTag) }}
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.dataset.controller.imagePrefix .Values.dataset.controller.imageName .Values.dataset.controller.imageTag . ) }}

Check warning

Code scanning / SonarCloud

Storage limits should be enforced

<!--SONAR_ISSUE_KEY:AZHv_MWZREFgCmEnHMZu-->Specify a storage limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZHv_MWZREFgCmEnHMZu&open=AZHv_MWZREFgCmEnHMZu&pullRequest=4319">SonarCloud</a></p>
charts/fluid/fluid/templates/controller/efcruntime_controller.yaml
#hostNetwork: true
containers:
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.runtime.efc.controller.imagePrefix .Values.runtime.efc.controller.imageName .Values.runtime.efc.controller.imageTag) }}
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.runtime.efc.controller.imagePrefix .Values.runtime.efc.controller.imageName .Values.runtime.efc.controller.imageTag . ) }}

Check warning

Code scanning / SonarCloud

Memory limits should be enforced

<!--SONAR_ISSUE_KEY:AZHv_MW0REFgCmEnHMZ5-->Specify a memory limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZHv_MW0REFgCmEnHMZ5&open=AZHv_MW0REFgCmEnHMZ5&pullRequest=4319">SonarCloud</a></p>
charts/fluid/fluid/templates/controller/thinruntime_controller.yaml
requests:
cpu: 100m
memory: 200Mi
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.runtime.thin.controller.imagePrefix .Values.runtime.thin.controller.imageName .Values.runtime.thin.controller.imageTag . ) }}

Check warning

Code scanning / SonarCloud

Storage limits should be enforced

<!--SONAR_ISSUE_KEY:AZHv_MUcREFgCmEnHMZK-->Specify a storage limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZHv_MUcREFgCmEnHMZK&open=AZHv_MUcREFgCmEnHMZK&pullRequest=4319">SonarCloud</a></p>
charts/fluid/fluid/templates/controller/vineyardruntime_controller.yaml
{{- end }}
containers:
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.runtime.vineyard.controller.imagePrefix .Values.runtime.vineyard.controller.imageName .Values.runtime.vineyard.controller.imageTag) }}
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.runtime.vineyard.controller.imagePrefix .Values.runtime.vineyard.controller.imageName .Values.runtime.vineyard.controller.imageTag . ) }}

Check warning

Code scanning / SonarCloud

Memory limits should be enforced

<!--SONAR_ISSUE_KEY:AZHv_MVmREFgCmEnHMZV-->Specify a memory limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZHv_MVmREFgCmEnHMZV&open=AZHv_MVmREFgCmEnHMZV&pullRequest=4319">SonarCloud</a></p>
charts/fluid/fluid/templates/controller/vineyardruntime_controller.yaml
{{- end }}
containers:
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.runtime.vineyard.controller.imagePrefix .Values.runtime.vineyard.controller.imageName .Values.runtime.vineyard.controller.imageTag) }}
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.runtime.vineyard.controller.imagePrefix .Values.runtime.vineyard.controller.imageName .Values.runtime.vineyard.controller.imageTag . ) }}

Check warning

Code scanning / SonarCloud

Storage limits should be enforced

<!--SONAR_ISSUE_KEY:AZHv_MVmREFgCmEnHMZW-->Specify a storage limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZHv_MVmREFgCmEnHMZW&open=AZHv_MVmREFgCmEnHMZW&pullRequest=4319">SonarCloud</a></p>
charts/fluid/fluid/templates/webhook/webhook.yaml
{{ include "fluid.controlplane.affinity" . | nindent 6}}
containers:
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.webhook.imagePrefix .Values.webhook.imageName .Values.webhook.imageTag) }}
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.webhook.imagePrefix .Values.webhook.imageName .Values.webhook.imageTag . ) }}

Check warning

Code scanning / SonarCloud

Storage limits should be enforced

<!--SONAR_ISSUE_KEY:AZHv_MXFREFgCmEnHMaA-->Specify a storage limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZHv_MXFREFgCmEnHMaA&open=AZHv_MXFREFgCmEnHMaA&pullRequest=4319">SonarCloud</a></p>
charts/fluid/fluid/templates/webhook/webhook.yaml
{{ include "fluid.controlplane.affinity" . | nindent 6}}
containers:
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.webhook.imagePrefix .Values.webhook.imageName .Values.webhook.imageTag) }}
- image: {{ include "fluid.controlplane.imageTransform" (list .Values.webhook.imagePrefix .Values.webhook.imageName .Values.webhook.imageTag . ) }}

Check warning

Code scanning / SonarCloud

Memory limits should be enforced

<!--SONAR_ISSUE_KEY:AZHv_MXFREFgCmEnHMZ_-->Specify a memory limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZHv_MXFREFgCmEnHMZ_&open=AZHv_MXFREFgCmEnHMZ_&pullRequest=4319">SonarCloud</a></p>
cheyang
cheyang approved these changes Sep 15, 2024
View reviewed changes
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Sep 15, 2024
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Sep 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 6f92548 into fluid-cloudnative:master Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TrafalgarZZZ @cheyang