Hi @omerap12. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.97%. Comparing base (22e808c) to head (e32e39d).
Report is 1 commits behind head on master.

@@            Coverage Diff             @@
##           master    #4293      +/-   ##
==========================================
+ Coverage   62.90%   62.97%   +0.07%     
==========================================
  Files         483      483              
  Lines       28570    28576       +6     
==========================================
+ Hits        17972    17996      +24     
+ Misses       8393     8375      -18     
  Partials     2205     2205              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheyang The _helper.tpl in runtime chart's directory has already truncate fullnameOverride to a maximum of 63 characters, here is the code.

@cheyang The _helper.tpl in runtime chart's directory has already truncate fullnameOverride to a maximum of 63 characters, here is the code.

fluid/charts/alluxio/templates/_helpers.tpl

Line 16 in 6ff32f9

{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" -}}

Should we do it again ?
Good Catch. FYI @omerap12 , I think we can just remove TODO.

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
8.8% Duplication on New Code

See analysis details on SonarCloud

@cheyang done :)

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here