Skip to content

Conversation

@TrafalgarZZZ
Copy link
Member

Ⅰ. Describe what this PR does

Add a timeout (default: 180s) to each e2e test case in Github Actions.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@TrafalgarZZZ TrafalgarZZZ force-pushed the enhance/add_timeout_gha_e2e branch from 9ea7eaa to 4d70ba8 Compare August 20, 2024 15:10
@cheyang
Copy link
Collaborator

cheyang commented Aug 21, 2024

@TrafalgarZZZ please take a look at the why E2E is failed.

@TrafalgarZZZ
Copy link
Member Author

@cheyang A typo makes the shell script crash. Already fixed it.

Signed-off-by: TrafalgarZZZ <trafalgarz@outlook.com>
Signed-off-by: TrafalgarZZZ <trafalgarz@outlook.com>
@TrafalgarZZZ TrafalgarZZZ force-pushed the enhance/add_timeout_gha_e2e branch from f787e12 to 1284f2c Compare August 21, 2024 14:23
@sonarqubecloud
Copy link

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit b96f0dd into fluid-cloudnative:master Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants